search

penumbra-zone / web

Apache License 2.0
10 stars 7 forks source link

minifront header menu work #1267

Closed turbocrime closed 2 weeks ago

turbocrime commented 2 weeks ago

fixes https://github.com/penumbra-zone/web/issues/1057

fixes https://github.com/penumbra-zone/web/issues/1080

fixes https://github.com/penumbra-zone/web/issues/1102

fixes https://github.com/penumbra-zone/web/issues/1221

removes most z-layer positioning of header elements

renders a tablet menu label on all pages

contains stub ui for disconnect. reports name, version, and icon of wallet from manifest

Screenshot 2024-06-10 at 15 58 14

this information about prax is fetched from prax's manifest

Screenshot 2024-06-10 at 15 58 47 Screenshot 2024-06-10 at 15 58 51
changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 7ec8b0957611855aa01bc47548a3848f623192ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | --------------------- | ----- | | @penumbra-zone/ui | Minor | | @penumbra-zone/client | Minor | | minifront | Patch | | node-status | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

TalDerei commented 2 weeks ago

I know this is currently still a work in-progress, but had some general comments.

https://github.com/penumbra-zone/web/issues/1102#issuecomment-2155070765 is relevant to the nav menu.

Additionally, the nav component shows 'dashboard' when you're on the dashboard page

Screenshot 2024-06-09 at 2 52 03 AM

but doesn't show the dashboard tab in the drop down menu when you're on another page

Screenshot 2024-06-09 at 2 52 14 AM

additionally, the drop down menu also moves around when navigating the page

https://github.com/penumbra-zone/web/assets/70081547/3b3f3153-b0b9-41ad-990f-aeba7687f5c4

also not sure how I feel about the green outline here, but that's a design question for @smmhrdmn

Screenshot 2024-06-09 at 2 58 54 AM
turbocrime commented 2 weeks ago

thanks for the link

other details are due to wip, i just pushed this to indicate im working on the component

turbocrime commented 2 weeks ago

edit: the green border is leftover from some debugging and it isn't intended to remain.

i plan to implement a more consistent appearance and behavior, and then i'll ping yall to take a look

turbocrime commented 2 weeks ago

cc @TalDerei @grod220 @smmhrdmn