Enforce sane inputs for the swap/auction UI - Githubissues

penumbra-zone / web

Apache License 2.0

10 stars 7 forks source link

Enforce sane inputs for the swap/auction UI #1286

Closed jessepinho closed 2 weeks ago

jessepinho commented 2 weeks ago

[x] Max output > min output
[x] Min output > 0 (incl. when the user clicks "Estimate" and there's no liquidity)
[x] Input asset !== output asset (somehow this got lost)
[x] Max/min outputs can not be greater than core's built-in limit of $2^{52} - 1$

Enforcing that max output is greater than min output, and that the two assets are not the same:

https://github.com/penumbra-zone/web/assets/1121544/760f109e-f1e3-4378-8396-b809588af08e

Enforcing a value greater than 0 for outputs:

https://github.com/penumbra-zone/web/assets/1121544/35c59fba-1dd2-47e8-a55e-3a96726a6739

Closes #1284 Closes #1224

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: d4e096f81eb0808b81216686175309ab82387adc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------- | ----- | | minifront | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR