penumbra-zone / web

Apache License 2.0
10 stars 7 forks source link

disintegration #1300

Closed turbocrime closed 1 week ago

turbocrime commented 1 week ago

makes interfaces reasonable

removes services-context package, querier package, storage package

creates block processor package, idb package

most of this diff is changing tests, which for some reason were heavily dependent on interfaces

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 96491ad9f00289e688f38f31af06b838dcce65f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages | Name | Type | | ------------------------------ | ----- | | @penumbra-zone/block-processor | Major | | @penumbra-zone/perspective | Major | | @penumbra-zone/services | Major | | @penumbra-zone/getters | Major | | @penumbra-zone/types | Major | | @penumbra-zone/wasm | Major | | @penumbra-zone/idb | Major | | @penumbra-zone/ui | Major | | minifront | Patch | | node-status | Patch | | @penumbra-zone/crypto-web | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

grod220 commented 1 week ago

I'll take a look at this more later in the afternoon, but after looking through 500+ lines of code, this does not feel like a reasonable chunk of code we can ship at once. There are meaningful changes to logic and code organization that we need to break down into multiple PRs.