search

penumbra-zone / web

Apache License 2.0
10 stars 7 forks source link

Stop using loader functions for swap page #1316

Closed jessepinho closed 6 days ago

jessepinho commented 1 week ago

This PR removes the loader function from the swap route, and instead uses ZQuery, resulting in instant route changes when a user navigates to /swap.

Closes #1243

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 8bc397d27e9077f041b41b4949a2475f5792dcbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

TalDerei commented 1 week ago

@jessepinho can you fold in this comment to reduce code duplication and have the warning use our shiny new zquery loaders?

jessepinho commented 6 days ago

@TalDerei

@jessepinho can you fold in this comment to reduce code duplication and have the warning use our shiny new zquery loaders?

Ah, sure — but I'm going to do that as a separate super-small PR, since as part of that, I want to calculate showNonNativeFeeWarning via a selector too, and that's out of scope for this PR.