search

penumbra-zone / web

Apache License 2.0
10 stars 7 forks source link

Asset filter box errors 🐛 #1328

Closed grod220 closed 6 days ago

grod220 commented 1 week ago

This looks related to the presence of unknown assets in the users balance

https://github.com/penumbra-zone/web/assets/16624263/4647466d-9a48-44f8-b37f-d16e3261e0d0

TalDerei commented 1 week ago

related to https://github.com/penumbra-zone/web/issues/1289?

Valentine1898 commented 1 week ago

The AssetSelector search does not actually take into account that the user may have unknown assets.

This is only reproduced for Send, because for Swap and Ibc we filter out unknown assets.

The search is based on display or symbol fields, and unknown assets do not have these fields.

Possible solutions:

  1. Filter out unknown assets for Send actions as well
  2. Simply ignore unknown assets for search
  3. Make the search more flexible, and make it possible to search both among known assets (by display and symbol fields) and unknown assets by bech32mAssetId.
Valentine1898 commented 1 week ago

I would favor

Simply ignore unknown assets for search