search

penumbra-zone / web

Apache License 2.0
10 stars 7 forks source link

web/ui #1342

Closed TalDerei closed 1 week ago

TalDerei commented 1 week ago

The idea of this PR is to prepare the UI package for extraction different components to Minifront and Prax. Here's what's done:

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: e9f30c572bfd516542a595f73bf7de65bc312c60

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

TalDerei commented 1 week ago
  • Returned the package name @penumbra-zone/ui back instead of @repo/ui

based on https://github.com/prax-wallet/web/pull/45#issuecomment-2182340891, prax won't be externally consuming the ui package, so we should revert back to using @repo/ui.

VanishMax commented 1 week ago

@TalDerei Changed the package name back to repo/ui

TalDerei commented 1 week ago

LGTM! I think this lays some really nice groundwork

https://github.com/prax-wallet/web/issues/51 is a good follow-up