search

penumbra-zone / web

Apache License 2.0
10 stars 7 forks source link

feat: #1169: add swap query params #1353

Closed VanishMax closed 3 days ago

VanishMax commented 5 days ago

Closes #1169

Adds support for from, to, and account query parameters on the Swap page. Also, adds a link from the assets table to trade each available asset.

Query params save asset.symbol string and compute the matches by it.

https://github.com/penumbra-zone/web/assets/29180358/ef89dba7-f00f-4d8b-b41d-88431b6a90a3

changeset-bot[bot] commented 5 days ago

⚠️ No Changeset found

Latest commit: f6642b5e7d9f75a882b28291c0539e9fc0e87306

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

VanishMax commented 4 days ago

@grod220 thanks for noticing! I addressed both the design and syncing the query params within the page. Also, added more tests for the swap state