penumbra-zone / web

Apache License 2.0
10 stars 7 forks source link

Shim Promise.withResolvers() for ZQuery and minifront tests #1355

Closed jessepinho closed 4 days ago

jessepinho commented 5 days ago

Not sure how this got removed. This PR makes sure tests pass when running with vitest — e.g., pnpm vitest packages/zquery

Before

image

After

image

changeset-bot[bot] commented 5 days ago

⚠️ No Changeset found

Latest commit: a7916aa143d5d7649581a5c2eb8fcc4aebe3e6bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/penumbra-zone/web/new/jessepinho/fix-zquery-tests?filename=.changeset/sharp-wasps-lie.md&value=---%0A%22minifront%22%3A%20patch%0A%22%40penumbra-zone%2Fzquery%22%3A%20patch%0A---%0A%0AShim%20Promise.withResolvers()%20for%20ZQuery%20and%20minifront%20tests%0A)

jessepinho commented 4 days ago

@turbocrime Ah, good catch! Thanks for calling that out. That was the issue. Closing this PR.