search

penumbra-zone / web

Apache License 2.0
10 stars 7 forks source link

Update revision number parsing #1365

Closed grod220 closed 3 days ago

grod220 commented 3 days ago

Our current parsing is inconsistent with the way the Rust core code is doing this. This PR aligns with the core implementation: https://github.com/penumbra-zone/ibc-types/blob/73da5ee5d06b5f62c186b31ce37f7669edc8bbf2/crates/ibc-types-core-connection/src/identifier.rs#L76-L87 so as to prevent bugs with potential chain ids.

changeset-bot[bot] commented 3 days ago

🦋 Changeset detected

Latest commit: 03f027d13226ca4c58a74c3688b13a5cee4a3075

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------- | ----- | | minifront | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

grod220 commented 3 days ago

Actually, this more pertains to IBC-in and ensuring that transactions are properly sending the right revision number (which is required on the cosmos message)