penumbra-zone / web

Apache License 2.0
12 stars 14 forks source link

swap and auction estimations fail #1423

Closed TalDerei closed 1 week ago

TalDerei commented 3 weeks ago

I've been getting this estimation error when trying to perform swaps / auctions.

Screenshot 2024-07-04 at 10 11 31 PM
jessepinho commented 2 weeks ago

Hm, I'm actually getting HTTP 412s (Precondition Failed). @TalDerei , which RPC are you using?

TalDerei commented 2 weeks ago

@jessepinho I don't recall, but it could be related to the fact that the RPC might not support simulation? In this context, it's not immediately clear to the user how much they're swapping if they need to manually inspect the transaction approval dialogue for that information.

tagging https://github.com/penumbra-zone/web/issues/936 as relevant

turbocrime commented 1 week ago

412 precondition failed likely means no price data is available to create an estimation. this will succeed if you make at least one trade.

408 unimplemented likely means the node operator has not run pd with --enable-expensive-rpc

turbocrime commented 1 week ago

i encountered both of these today and i believe they were visible in console, will take another look at error propagation soon

jessepinho commented 1 week ago

408 unimplemented likely means the node operator has not run pd with --enable-expensive-rpc

Ah — can production RPC nodes run pd without that flag? If so, sounds like we need to handle that case.

hdevalence commented 1 week ago

The released version of pd makes that flag a no-op, but yeah, error handling would be good.

TalDerei commented 1 week ago

Ah — can production RPC nodes run pd without that flag? If so, sounds like we need to handle that case.

Screenshot 2024-07-17 at 6 17 23 AM Screenshot 2024-07-17 at 6 18 56 AM
TalDerei commented 1 week ago

closing due to the inclusion of https://github.com/penumbra-zone/penumbra/issues/4696 in v0.79.0 per discussions during the weekly sync. cc @hdevalence