search

penx / govuk-colours

GOV.UK standard colours as JavaScript constants.
5 stars 4 forks source link

TypeScript support #9

Open domdomegg opened 2 years ago

domdomegg commented 2 years ago

TypeScript definitions so this plays nice with IDEs would be nice.

debitan commented 1 year ago

Hi @penx 👋

I was looking at the bigger issue of enabling strict mode in govuk-react and noticed that some errors generating when running strict TS checking on that project were related to the fact that this package didn't support TypeScript. So I put together a quick PR to address TypeScript support here. However, I can't push a branch without authorisation. Is this something that could be arranged and maybe we could close out this issue?

Many thanks!

debitan commented 1 year ago

Please ignore that request for authorisation above. This is my first open source PR 😅 and I'm just learning about the "fork and pull request" workflow!