check if response.setEncoding function exist

peol / node-spotify

A very simple node.js library for the Spotify REST API

42 stars 17 forks source link

check if response.setEncoding function exist #6

Closed triptec closed 11 years ago

triptec commented 11 years ago

this function doesn't exist on all clients

peol commented 11 years ago

Which clients (do you mean non node.js?) does not support it?

triptec commented 11 years ago

On Mar 25, 2013, at 9:26 AM, Andrée Hansson notifications@github.com wrote:

Which clients (do you mean non node.js?) does not support it?

— Reply to this email directly or view it on GitHub.

peol commented 11 years ago

So you're using this in a browser? It's a node.js module, didn't know browsers could use them...

triptec commented 11 years ago

On Mar 25, 2013, at 12:11 PM, Andrée Hansson notifications@github.com wrote:

So you're using this in a browser? It's a node.js module, didn't know browsers could use them...

— Reply to this email directly or view it on GitHub.

triptec commented 11 years ago

On Mar 25, 2013, at 12:34 PM, Andreas Franzén andreas.f@osynlig.se wrote:

yeah http got a client lib that has the basic functions ANDREAS FRANZEN | DEVELOPER | M +46 60 52 52 19 | ANDREAS.FRANZEN@OSYNLIG.SE Osynlig AB | Torggatan 8, 3rd floor | S-85230 Sundsvall | +46 60 525 220 | osynlig.se

On Mar 25, 2013, at 12:11 PM, Andrée Hansson notifications@github.com wrote:

So you're using this in a browser? It's a node.js module, didn't know browsers could use them...

— Reply to this email directly or view it on GitHub.

peol commented 11 years ago

That's fine, just wanted to make sure we didn't pull in any unnecessary logic :)

Could you please format it though, I'd like to have all code in the library with brackets, even if it's one-liners. So:

if (foo)
    // code

to:

if (foo) {
    // code
}

Thanks!