search

peonso / opentibia_sprite_pack

Free to use sprites from the OpenTibia community. The images here are available under the Creative Commons Attribution 4.0 International license.
Creative Commons Attribution 4.0 International
74 stars 24 forks source link

TFS bug #8

Open peonso opened 6 years ago

peonso commented 6 years ago

Actual bug with TFS, nothing can be done at our side. This is hardcoded, should be commented out/removed:

https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L70-L81

Znote commented 6 years ago

Did you post an issue about it on the TFS repo? Hardcoded itemids in C++ is bad. It should at least be from a configurable lua or xml file.

What about: https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L1237

https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L1315

https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L1379

peonso commented 6 years ago

@Znote I didn't noticed it because the pack didn't have those high ids. I also didn't posted it there because I didn't have a suggestion to address it.

peonso commented 6 years ago

https://github.com/otland/forgottenserver/blob/18fbfdc33a65c5cba9d5a02bcc8116dfd10362b0/src/protocolgame.cpp#L2631

https://github.com/otland/forgottenserver/blob/18fbfdc33a65c5cba9d5a02bcc8116dfd10362b0/src/protocolgame.cpp#L1444