search

people-os / support-shift-scheduler

Project for scheduling balena engineers for customer support
Apache License 2.0
34 stars 8 forks source link

Standardize Zulip emails #426

Closed pranasziaukas closed 12 months ago

pranasziaukas commented 12 months ago

Standardize (lowercase) Zulip emails, which are user-configurable.

We could also lowercase email coming from the Team Model

https://github.com/people-os/support-shift-scheduler/blob/f86c232be526c00a3cd4f7f1e4b5c2746015c2f0/helper-scripts/beautify-schedule.ts#L233

but maybe it's fair to assume that these are already standardized?

gantonayde commented 12 months ago

@pranasziaukas I created another PR before checking if there is already one, sorry. It also adds standardization for the emails coming from the teamwork model. These come from the full team model and it is a long chain that needs to be followed if something goes wrong. It is better to convert everything to lower case here.

edit: Of course, I forgot to run balena-lint fix and the PR failed the checks...

pranasziaukas commented 12 months ago

Duplicate of #427