peopledoc / django-chartjs

Django Class Based Views to generate Ajax charts js parameters.
Other
404 stars 112 forks source link

Make all get_context_data methods call their super-method and update context #17

Closed choller closed 6 years ago

jpic commented 7 years ago

It doesn't pass QA checks:


chartjs/views/__init__.py:1:1: E265 block comment should start with '# '
chartjs/views/__init__.py:23:25: W291 trailing whitespace
chartjs/views/__init__.py:24:20: E203 whitespace before ':'
chartjs/views/__init__.py:25:26: E203 whitespace before ':'
chartjs/views/__init__.py:26:21: E203 whitespace before ':'
chartjs/views/__init__.py:27:22: E203 whitespace before ':'
chartjs/views/lines.py:13:25: E201 whitespace after '{'
chartjs/views/lines.py:13:34: E203 whitespace before ':'
chartjs/views/lines.py:13:66: E203 whitespace before ':'
chartjs/views/lines.py:13:80: E501 line too long (90 > 79 characters)
chartjs/views/lines.py:13:88: E202 whitespace before '}'
chartjs/views/lines.py:58:80: E501 line too long (81 > 79 characters)
chartjs/views/columns.py:17:80: E501 line too long (83 > 79 characters)
Natim commented 7 years ago

@choller Do you mind fixing the tests?

Natim commented 6 years ago

Superseeded by #37