search

peopledoc / django-chartjs

Django Class Based Views to generate Ajax charts js parameters.
Other
404 stars 112 forks source link

Update README.rst #52

Closed edras closed 4 years ago

edras commented 4 years ago

included additional information about urls.py

Natim commented 4 years ago

Thank you for starting this PR.

I think that generally it is best to define views in the views.py file and then import the view in the urls.py file.

It makes things more readable. What do you think?

edras commented 4 years ago

I am following what is described in django 3.0 documentation https://docs.djangoproject.com/en/3.0/topics/class-based-views/

In my projects, I import the view and call the classes as needed in my urls.py But I am Ok in keeping things readable.

Best regards,

Edras R. Pacola edras.pacola@gmail.com Engenheiro Eletrônico

"Engenheiro: agente de transformações tecnológicas e sociais."

Am Di., 5. Mai 2020 um 13:22 Uhr schrieb Rémy HUBSCHER < notifications@github.com>:

Thank you for starting this PR.

I think that generally it is best to define views in the views.py file and then import the view in the urls.py file.

It makes things more readable. What do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/peopledoc/django-chartjs/pull/52#issuecomment-624155536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD2IQRE4W4BJOXGJBCRCVTRQA4M3ANCNFSM4MZWTBWA .