search

peopledoc / django-mail-factory

Django Mail Manager
Other
72 stars 17 forks source link

Release 0.18 #73

Closed wo0dyn closed 7 years ago

wo0dyn commented 7 years ago

This release fixes #71.

Natim commented 7 years ago

Strange to have both commit in the same PR 🇼🇸

wo0dyn commented 7 years ago

Strange to have both commit in the same PR

Ah? We always do this process everytime everywhere. :confused: The PR should be reviewed commit by commit though.

Natim commented 7 years ago

Are you using zest.releaser? You can do the following:

  1. use the prerelease to create the first commit
  2. File the PR and have it reviewed.
  3. Merge it
  4. Run release to release the package
  5. Run postrelease to commit the last commit and push it with the tag
wo0dyn commented 7 years ago

@Natim Yes, I used zest.releaser. OK for this process. But that means you have to push a commit on master without a PR.

Natim commented 7 years ago

But that means you have to push a commit on master without a PR.

Yes but it is an automatic one, that you can have reviewed today for all of them.

wo0dyn commented 7 years ago

Yes but it is an automatic one, that you can have reviewed today for all of them.

OK. Will do :)