search

peopledoc / eslint-config-peopledoc

ESLint config for PeopleDoc frontend projects
MIT License
1 stars 1 forks source link

Initial review #2

Closed xcambar closed 7 years ago

xcambar commented 7 years ago

Thanks @edouard-lopez for this. ping @peopledoc/team-js for an initial review and discussion.

I required this to be small so it can move fast, so let's move!

GreatWizard commented 7 years ago

it sounds good for a start. Anyone try it in a project to see the behavior?

I just take a look at suave rules and the have "es6 standard rules" in the recommended config. We should take a look at them because we may want it for all the JS projects: https://github.com/DockYard/eslint-plugin-ember-suave/blob/master/config/recommended.js#L15-L27

GreatWizard commented 7 years ago

Even if we don't have any specific rules yet, we should consider add tests to just verify that eslint is working on a simple example for both config

xcambar commented 7 years ago

And these rules can help build a living styleguide, so that's a very good idea!