peopledoc / eslint-config-peopledoc

ESLint config for PeopleDoc frontend projects
MIT License
1 stars 1 forks source link

feat: semi error never #35

Closed 4www closed 6 years ago

4www commented 6 years ago

Closes https://github.com/peopledoc/eslint-config-peopledoc/issues/15

In this PR:

Tested on a peopledoc project, and it seems to work without issue.

Further readings on semi or not:

How to implement?

To make the transition from semi, to no-semi, this script can be be helpful.

Add it to the script section of your projects package.json, and update this module to the version that will be released:

// package.json
{
[...]
  "scripts": {
    "prettier": "./node_modules/.bin/prettier-eslint --write --single-quote {app,config,mirage,lib,server,tests}/{**/,}*.js"
  }
[...]
  {
    devDependencies: {
      "eslint-config-peopledoc": "github:peopledoc/eslint-config-peopledoc#v1.4.0",
    }
  }
[...]
}

And then run npm run prettier, to clean all semicolons from your javascript files.

edouard-lopez commented 6 years ago

@hugurp :+1:
Might be good to add the How to implement? section to the release note for 1.4.0 so other team don't have to dive into issues to find how to do it