peopledoc / eslint-config-peopledoc

ESLint config for PeopleDoc frontend projects
MIT License
1 stars 1 forks source link

Some essential rules are not linted anymore in v2.0.0 #50

Closed MrChocolatine closed 4 years ago

MrChocolatine commented 4 years ago

An essential rule ember/avoid-leaking-state-in-ember-objects is not linted anymore with the version 2.0.0 of this package, and using Ember >= 3.12 does not necessarily mean everything is a class (where this rule would be useless).

With this version installed, I had to manually add the rule 'ember/avoid-leaking-state-in-ember-objects': 2, to my ESLint config file to see the warning again in a "classic component".

export default Component.extend({
  toto: [ 666 ], // should trigger the error in such a "classic component"
})

For the time being, it looks like it is not wise to use this version and we should stay on a version < 2.0.0.

Ping @peopledoc/tribe-js.