search

peopledoc / eslint-config-peopledoc

ESLint config for PeopleDoc frontend projects
MIT License
1 stars 1 forks source link

Config `ember-test` is not relevant anymore #69

Closed MrChocolatine closed 3 years ago

MrChocolatine commented 3 years ago

Config ember-test is not relevant anymore and could be deleted.

  1. server is no longer a global symbol.

    server was a global symbol with Ember.js < v3.0.0 in with ember-cli-mirage < v1.0.0: https://github.com/miragejs/ember-cli-mirage/blob/bf4ac5a8a7245c32c8a502bfcaf4bff5f3a30880/tests/dummy/app/pods/docs/writing-your-server/acceptance-testing/template.md

    Mirage's server should now be accessed through this.server: https://github.com/miragejs/ember-cli-mirage/blob/f9520f18f37636ef8ccd452342a4ad877f1b5311/tests/dummy/app/pods/docs/testing/acceptance-tests/template.md#L26

  2. The predefined environment embertest is not relevant anymore.

    https://github.com/sindresorhus/globals/blob/c68458b91ae4d0dbcdc263f8c842d9f72b630b56/globals.json#L1629-L1645

All those functions are now accessed through this or through the add-on ember-test-helpers.