search

peopledoc / pydocusign

Python client for DocuSign signature API
Other
18 stars 21 forks source link

Pydocusign overwriting an urllib3 Response method with a Requests Response method #94

Closed kbussell closed 8 years ago

kbussell commented 8 years ago

https://github.com/novafloss/pydocusign/blob/master/pydocusign/client.py#L483

response.raw is an urllib3 response object. response.close is a method on a Requests Response object. I'm not sure why this was added in the first place, but this should not work.

It's possible that older versions of Requests and urllib3 had a bug around this, but using 2.9.0 and up, this line doesn't do anything useful and could be harmful.

kbussell commented 8 years ago

Note: I ran into a bug with this a while back and had patched this in our custom build of this library to remove that line. The only note I had was that things started breaking when upgrading to Requests 2.9 (from v2.7).

We've been running in production with requests 2.9 since its release in December, and things have worked well.

Hopefully this is enough to consider removing this line.