peopledoc / vault-cli

A configurable command-line interface tool (and python library) to interact with Hashicorp Vault
https://vault-cli.readthedocs.io/
Other
80 stars 21 forks source link

Fixes #135 trailing slash in path issue in `get-all` and `delete-all` #140

Closed SdgJlbl closed 4 years ago

SdgJlbl commented 4 years ago

Co-Authored-By: Joachim Jablonewjoachim@gmail.com

Cf. #135

Check list:

codecov[bot] commented 4 years ago

Codecov Report

Merging #140 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #140   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         814    818    +4     
  Branches      104    104           
=====================================
+ Hits          814    818    +4
Flag Coverage Δ
#integration 67.11% <50%> (-0.09%) :arrow_down:
#unit 100% <100%> (ø) :arrow_up:
Impacted Files Coverage Δ
vault_cli/client.py 100% <100%> (ø) :arrow_up:
vault_cli/testing.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90d6c41...c538b05. Read the comment docs.

SdgJlbl commented 4 years ago

Problem also impacts the library, so fixing in client.py seems more relevant.