[Vault_cli][SSH] ssh-add message

[jybeepeopledoc]

Bonjour à tous,

lors de l'utilisation de vault_cli avec l'option ssh, le message de ssh-add s'affiche.

/usr/local/bin/vault --config-file /etc/{SERVICE}/vault_ro.yml ssh --key {PATH}:{VALUE}

Identity added: (stdin) ((stdin))

Est-il possible de rendre cette affichage optionnel afin de pouvoir le désactiver (notamment lors de l'utilisation via cron) ?

[ewjoachim]

Hey :) Don't forget this is an open source repo, the whole world is watching (well maybe not the whole world but at least non-french-speaking folks)

Yep, ssh-add seems to support -q for quiet mode, suppressing message for succesful operations. If you can afford a bit of time, is there any way I can help you contributing and adding this? We can do it in pair if you want !

Note: the whole contribution will be:

One change here to add -q: https://github.com/peopledoc/vault-cli/blob/b76336ead4bc24acfc2a9ab5e44e169da6064d1c/vault_cli/ssh.py#L38 One line here to test: https://github.com/peopledoc/vault-cli/blob/b76336ead4bc24acfc2a9ab5e44e169da6064d1c/tests/integration/test_integration.py#L193 Unit tests to fix: https://github.com/peopledoc/vault-cli/blob/100e3b2cfbf0a170a0966208ab5b92a0bb874934/tests/unit/test_ssh.py#L38 and https://github.com/peopledoc/vault-cli/blob/100e3b2cfbf0a170a0966208ab5b92a0bb874934/tests/unit/test_ssh.py#L44 Changelog: https://github.com/peopledoc/vault-cli/blob/b76336ead4bc24acfc2a9ab5e44e169da6064d1c/CHANGELOG.rst#L10

That's it :) If you need me, I'll be there, and happy to help :)

And welcome to the wonderful world of open source contributions!

(note: if you don't have time to do it or prefer not to, just tell me)