search

peopledoc / vault-cli

A configurable command-line interface tool (and python library) to interact with Hashicorp Vault
https://vault-cli.readthedocs.io/
Other
81 stars 21 forks source link

implemented a cp function #181

Closed soualid closed 3 years ago

soualid commented 3 years ago

Closes #119

Successful PR Checklist:

Needed this option, ran into your utility, and discovered it was missing.

It's almost the first time I code something using python, don't hesitate to tell me if something is wrong! :slightly_smiling_face:

ewjoachim commented 3 years ago

Can I ask you to rebase on master or to merge master into your branch ?

soualid commented 3 years ago

Sure

soualid commented 3 years ago

Rebased and pushed. :ok_hand:

codecov[bot] commented 3 years ago

Codecov Report

Merging #181 (fa7aa0e) into master (14a8fff) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #181   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          916       938   +22     
  Branches       116       120    +4     
=========================================
+ Hits           916       938   +22
Impacted Files Coverage Δ
vault_cli/cli.py 100.00% <100.00%> (ø)
vault_cli/client.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7cc548...d99c863. Read the comment docs.

ewjoachim commented 3 years ago

Looks like there's a very slight hole in coverage: copy_secrets is never called with generator=False, so there's a branch of code that is not tested.

soualid commented 3 years ago

Sure, I was missing the client tests, which are using this generator parameter. I just implemented them and we should be good by now! Cheers.

ewjoachim commented 3 years ago

Well I can only say congratulations :) And you said it was one of your first Python PRs, I'm really impressed !

I'm going to make a release :)

ewjoachim commented 3 years ago

https://pypi.org/project/vault-cli/