No messages appearing on PRs despite re-installation

[desilinguist]

We are no longer receiving any comments on our PRs in our public repository. It used to work perfectly a few months ago when we did our last release. I uninstalled the app an reinstalled it via the marketplace but that didn't change anything. I checked our .pep8speaks.yml file and it's still there and correctly formatted. Any help figuring this out would be greatly appreciated! We really love the functionality that pep8speaks provides – it makes things so much easier for us.

[OrkoHunter]

Hey @desilinguist, thank you for creating the issue and using pep8speaks. :)

The service seems to be up since the latest public comment was few minutes ago. :)

I doubt that GitHub is not sending payloads from the repository. Can you please check again how the app is installed? Have you installed it on a few repos, or all the repos, and if that is on your personal account or on the EducationalTestingService org? Screenshots might help me.

I can then manually mock a payload from the repository for a Pull Request and see if there are any technical issues.

[desilinguist]

Hi @OrkoHunter ! Thank you so much for the prompt reply. It's much appreciated.

Originally, I had installed pep8speaks outside of the GitHub marketplace. However, this morning, since it wasn't working, I uninstalled it and reinstalled it from inside the marketplace. I installed it in the EducationalTestingService organization and gave it access to the couple of repos that we use it with. Below are the two screenshots that show this. Please let me know if you need anything else.

[OrkoHunter]

In my test PR here, I manually mocked the payload which GitHub is supposed to send to PEP8Speaks server. That resulted in an expected comment.

So, the problem here is that GitHub is not sending payloads for the repository. I will look into it more.

[desilinguist]

Thank you so much for looking into this!

---

From: Himanshu Mishra notifications@github.com Sent: Wednesday, September 30, 2020 2:55:59 AM To: OrkoHunter/pep8speaks pep8speaks@noreply.github.com Cc: Nitin Madnani nmadnani@gmail.com; Mention mention@noreply.github.com Subject: Re: [OrkoHunter/pep8speaks] No messages appearing on PRs despite re-installation (#184)

In my test PR herehttps://github.com/EducationalTestingService/rsmtool/pull/473, I manually mocked the payload which GitHub is supposed to send to PEP8Speaks server. That resulted in an expected comment.

So, the problem here is that GitHub is not sending payloads for the repository. I will look into it more.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/OrkoHunter/pep8speaks/issues/184#issuecomment-701197752, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AABHPEAL3FQINALIQUGN5JTSILI77ANCNFSM4R535G6A.

[dalmia]

Any updates on this? @OrkoHunter We are also facing the same issue as you mentioned. Looking forward to your comment. Thank you for building pep8speaks :)

[OrkoHunter]

Hello @dalmia ! Thank you :) I have been looking into this issue on and off again with no success.

Could you help out with some details?

• Which repositor(y/ies) did you install the GitHub app on?
• Have you not seen a pep8speaks comment on any PRs?

Thanks!

[dalmia]

Thanks for getting back so quickly, @OrkoHunter! :)

• Unfortunately, it is a private repository that we intend to open-source soon!
• No, we haven't seen any pep8speaks comment on any PR - we installed it 2 weeks ago!

Can you share a mock payload as you have used above to replicate and confirm that this is indeed the issue for us too? Also, any reason that this would work for one service (your first comment in this thread) and not for another one?

[OrkoHunter]

Hey @dalmia ! @pep8speaks by default does not work with private repos since the bot needs access to comment. This issue is about the bot not commenting on a public repo.

See this for more details https://github.com/orkohunter/pep8speaks#private-repos

https://gist.github.com/OrkoHunter/8bdbba46327df13ce3f89e6dcbdfa59c This is a mock payload I use to test against a local PEP8Speaks server.

[dalmia]

Thanks for clarifying that and providing the link to the guidelines for a private repo, @OrkoHunter!

[carterbox]

I stopped receiving comments on my public repo from pep8speaks sometime in November of 2020. Are there any debugging/troubleshooting steps I can follow?

[desilinguist]

This has still not worked for us and we have switched to using pre-commit hooks instead.

[OrkoHunter]

@carterbox Thanks for the link to the issue, I can reproduce a payload from GitHub to see if something is wrong with the server or whether GitHub has stopped sending payloads in some settings.

Meanwhile, the pep8speaks is still actively commenting on a lot of the PRs out there. (last one being 2 hours ago) https://github.com/search?o=desc&q=commenter%3Apep8speaks&s=created&type=Issues

@desilinguist pre-commits are awesome and I use them too! Appreciate you sharing it here. :)

[OrkoHunter]

@carterbox I simulated a GitHub payload for the PR https://github.com/tomography/tike/pull/101 and sent it to the server, and the bot updated the comment.

I am not sure what's going on with automated payloads from GitHub. Let me create a test PR on your repository and verify whether a payload is being sent or not. Thanks!

[OrkoHunter]

Huh, I created a new PR and the bot commented. https://github.com/tomography/tike/pull/120

@carterbox PEP8Speaks will not comment on a PR if there are no errors. You can change this behavior by setting no_blank_comment: False in .pep8speaks.yml https://github.com/orkohunter/pep8speaks#configuration

[carterbox]

@OrkoHunter, I didn't expect that the default option was to be silent without errors! Thanks for your help debugging this for me! I guess pep8speaks has trained my contributors to lint their own code!

[OrkoHunter]

Closing this issue since the original author has moved away. To new users: feel free to open a new issue with details, and I'll help out!