pep8speaks-org / pep8speaks

A GitHub :octocat: app to automatically review Python code style over Pull Requests
https://pep8speaks.org
MIT License
606 stars 88 forks source link

Expand with flake8 plugins? #56

Open dopplershift opened 7 years ago

dopplershift commented 7 years ago

Any thoughts on using flake8 (which uses pycodestyle) and adding some additional flake8 plugins?

OrkoHunter commented 6 years ago

Sounds good. I'm little unsure about how this will work. Does a configuration to use flake8 instead of pycodestyle work?

dopplershift commented 6 years ago

That would work. Any idea on how to handle adding plugins? Or would that just have a whitelist of them baked into pep8speaks?

OrkoHunter commented 6 years ago

TBH I have never used flake8 myself. Do we not just use flake8 command line tool with arguments (just like pycodestyle/pep8) ? I googled "flake8 plugins" but nothing relevant came in.

dopplershift commented 6 years ago

So you first need to install additional packages, like flake8-print. These plugins are then active by default, but then sometimes you have custom configuration for them, though for all of my projects I can put that configuration in setup.cfg.