search

pep8speaks-org / pep8speaks

A GitHub :octocat: app to automatically review Python code style over Pull Requests
https://pep8speaks.org
MIT License
608 stars 87 forks source link

Rewrite on GitHub's GraphQL API #58

Open chinskiy opened 7 years ago

chinskiy commented 7 years ago

Greetings @OrkoHunter How do you like the idea to rewrite pep8speaks with GraphQL API? https://developer.github.com/v4/

dibyadas commented 7 years ago

Hi @chinskiy, That's a nice idea. But I wonder how much it will help in the case of pep8speaks? . GraphQL's most powerful advantage is that one request can replace multiple REST API requests. I just had a quick glance at the code and noticed that most of the modules in helpers.py and handlers.py have at most 1 API call with the exception of 2-3 modules where 2 API calls are made. Thus, my concern.

chinskiy commented 7 years ago

Hi @dibyadas To one plus u have said I can also add reduce downloading superfluous data. For me it's tempting to rewrite request logic in pep8speaks on GraphQL. but u are right, it's don't give many benefits for pep8speaks now.