search

pepegar / hammock

Purely functional HTTP client
https://hammock.pepegar.com/
MIT License
176 stars 20 forks source link

Use cats-effect bracket #104

Open pepegar opened 6 years ago

pepegar commented 6 years ago

We should use it for interpreters, where the class instantiating InterpTrans uses the lower level interpreter as a resource that's aquired, used and released afterwards.

miciek commented 6 years ago

Happy to help with this one.

pepegar commented 6 years ago

Awesome @miciek ! Do you have a proposal for it? or do you prefer discussing the design a bit here?

miciek commented 6 years ago

I will try to propose something and then we can discuss further. Thanks :)

pepegar commented 6 years ago

Sounds good! Thanks @miciek !

miciek commented 6 years ago

@pepegar I gave it some time and now I wonder whether you want to implement something in each Interpreter for acquiring clients (around doReq) or maybe in InterpTrans.trans or HammockFSyntax.exec?

I know that each of them solves a different problem, so it would be nice if you shared some thoughts on this topic :) Thanks!