search

pepfar-datim / datim-mechanism-finder

DATIM app for finding mechanisms
Other
0 stars 0 forks source link

Minimum Viable Product - Review #27

Open tomzemp opened 5 years ago

tomzemp commented 5 years ago

Hi @benguaraldi @jakub-bao:

I have a minimum viable product of the React datim mechanism finder app deployed on dev-tom.datim.org (it's called DATIM Mechanism Finder whereas the old Angular one is called Mechanism Finder

image

I wrote a couple of cypress tests when I started, but I can go back and now write them more fully. Other than that, I'm not sure what you want to do in terms of review/soliciting feedback

benguaraldi commented 5 years ago

Looks great, @tomzemp! A few minor comments and a major one.

Minor comments first:

  1. It seems like it's having trouble loading the DATIM logo:

    Screen Shot 2019-07-02 at 1 23 12 PM

  2. The table doesn't span the same width as the three boxes: Screen Shot 2019-07-02 at 1 29 46 PM

  3. Having the scroll bar at the bottom of the window rather than at the bottom of the page is fantastic! It's a better solution than having it in the middle of the page, as I proposed.

Now the major issue. As I clicked around, I saw some bizarre formatting issues. Are these anything that you've seen before? I didn't do anything remarkable—simply clicked between the two options of where to search for more info: Screen Shot 2019-07-02 at 1 25 05 PM Screen Shot 2019-07-02 at 1 24 46 PM Screen Shot 2019-07-02 at 1 24 14 PM Screen Shot 2019-07-02 at 1 24 07 PM

Once these are all resolved, maybe let's take it back to Josephine and someone from the PMO side to review, and then plan for a deploy?

tomzemp commented 5 years ago

@benguaraldi @jakub-bao I redid the styles (https://github.com/pepfar-datim/datim-mechanism-finder/issues/19#issuecomment-519944654)

and now it looks like I'm not getting weird styling problems when things are rerendered mechFinderDevTom

Also (logo is fixed :-) )

I will plan on passing back to Josephine, Celeste, and Michelle for comments unless I hear otherwise from you.

jakub-bao commented 5 years ago

congratulations!!

benguaraldi commented 5 years ago

@tomzemp Please pass on to Josephine, Celeste, and Michelle for comments. Can they also test it, or should someone else do that?