Closed rcrichton closed 8 years ago
@rcrichton @BMartinos FYI you're both merging into different branches (master and dat-32- respectively). Maybe just liase with each other before merging.
@rcrichton sorry missed I few extra things - I only thought about these as I was reading through Martin's PR.
@hnnesv thanks, seems I forgot to do a bunch of stuff, sorry.
I should have been merging with the dat-32 branch, I've corrected that now.
@hnnesv ready for re-review
👍 LGTM
@rcrichton LGTM - there's just an extra console.log but feel free to go ahead and merge after removing 👍