pepijndevos / LolItemSets

Optimize LoL builds for specific parameters
http://pepijndevos.nl/LolItemSets/
Eclipse Public License 1.0
0 stars 1 forks source link

Shows icons for each item in the build #22

Closed aengelberg closed 8 years ago

aengelberg commented 9 years ago

Also hides the detailed item view during generation (really helps speed)

pepijndevos commented 9 years ago

I kinda liked all the things flashing around during optimization. But if it slows down things a lot you could also just not update recommended items until generation is done.

But sometimes it's stable before it's done generating, so in that case it would not show anything while the set is basically done, Maybe updating the ui at a fixed interval is a good solution. I'm sure there is some core.async pattern for that.

aengelberg commented 9 years ago

The thumbnails change in real time, so in that sense it's flashing around (and I like that). But I am well-versed enough in League items that I highly prefer to only see the item icons. The user has the option to scroll down and see the title / description of the items AFTER the algorithm is done.

It's way faster because only the images have to be re-rendered in each iteration, not the title and description as well.

pepijndevos commented 9 years ago

Sounds like a fair trade-off then,