pepkit / eido

Validator for PEP objects
http://eido.databio.org
BSD 2-Clause "Simplified" License
5 stars 6 forks source link

v0.1.6 #32

Closed stolarczyk closed 2 years ago

stolarczyk commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #32 (5a49785) into master (6e5a80a) will decrease coverage by 5.66%. The diff coverage is 54.83%.

:exclamation: Current head 5a49785 differs from pull request most recent head d90c820. Consider uploading reports for the commit d90c820 to get more accurate results

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   78.90%   73.23%   -5.67%     
==========================================
  Files          10       13       +3     
  Lines         275      355      +80     
==========================================
+ Hits          217      260      +43     
- Misses         58       95      +37     
Impacted Files Coverage Δ
eido/conversion_plugins.py 11.36% <11.36%> (ø)
eido/validation.py 61.11% <25.00%> (-1.75%) :arrow_down:
eido/conversion.py 62.96% <58.33%> (+21.02%) :arrow_up:
eido/exceptions.py 76.92% <75.00%> (-3.08%) :arrow_down:
tests/test_validations.py 95.38% <85.00%> (-4.62%) :arrow_down:
eido/__init__.py 100.00% <100.00%> (ø)
eido/_version.py 100.00% <100.00%> (ø)
eido/schema.py 97.29% <100.00%> (+0.07%) :arrow_up:
tests/test_conversions.py 100.00% <100.00%> (ø)
tests/test_schema_operations.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5e87a9...d90c820. Read the comment docs.

nsheff commented 3 years ago

hi @stolarczyk can we finalize this PR?

nsheff commented 2 years ago

@stolarczyk Just wanting to get these peppy/eido releases out. Can you check on the status of this PR? Peppy 0.32.0 is nearing release.

stolarczyk commented 2 years ago

Looks good to me