Closed rafalstepien closed 1 year ago
@nsheff can I have your comment here? Which option looks better for you?
Also @nleroy917 @Khoroshevskyi I would love to hear what do you think.
Actually I didn't know that eido provides positional --st-index
argument which actually solves the problem (facepalm).
then the only way to specify this and allow correct validation from command line is to have config.yaml defining new sample table index column name.
Not exactly. Another way is to just pass the name of the index column as a command-line argument. Another way is to assume that the first column is the index column.
Actually I didn't know that eido provides positional
--st-index
argument which actually solves the problem (facepalm).
Ok, great.
Another option is to change to:
1. Value specified in Project constructor
2. Value specified in Config
3. Default value (sample_name)
4. If no match, use the first column
The schema specification doesn't make sense, because it would make the peppy Project constructor rely on the schema. You can, of course, get the value from the schema yourself, and then just pass it to the project constructor. But don't make peppy require a schema for creating a Project.
Latest updates in pepkit allowed users to use PEP without
config.yaml
- just havingsample_table.csv
; however whensample_table.csv
does not havesample_name
column (eg. it hassample
instead) then the only way to specify this and allow correct validation from command line is to haveconfig.yaml
defining new sample table index column name.What we need is to make sure eido can validate only
sample_table.csv
withoutconfig.yaml
even whensample_table
has different index column name. The idea is to allow user passing this information toschema.yaml
and make eido read that.Possible options:
schema.yaml
as index column"Tasks to do here:
sample_table.csv
withoutconfig.yaml
in case of differentindex_column_name