pepkit / geofetch

Builds a PEP from SRA or GEO accessions
https://pep.databio.org/geofetch/
BSD 2-Clause "Simplified" License
45 stars 5 forks source link

v0.12.3 #120

Closed khoroshevskyi closed 1 year ago

khoroshevskyi commented 1 year ago
nsheff commented 1 year ago

I think something like this would be complexity O(s*a) instead of O(s*a*a):

keys = {"sample_name": None}

for sample in list_of_dict:
    for element in sample.keys():
        keys[element] = None

return keys.keys()
codecov[bot] commented 1 year ago

Codecov Report

Merging #120 (87d4149) into master (3ad1dda) will increase coverage by 0.14%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   67.08%   67.22%   +0.14%     
==========================================
  Files          11       11              
  Lines        1662     1663       +1     
==========================================
+ Hits         1115     1118       +3     
+ Misses        547      545       -2     
Impacted Files Coverage Δ
geofetch/_version.py 100.00% <100.00%> (ø)
geofetch/utils.py 74.50% <100.00%> (+0.07%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more