pepkit / looper

A job submitter for Portable Encapsulated Projects
http://looper.databio.org
BSD 2-Clause "Simplified" License
20 stars 7 forks source link

toggle #263

Closed nsheff closed 1 year ago

nsheff commented 4 years ago

-toggle-key should be folded into selector attributes

-sel-attr defaults to 'toggle' -sel-incl defaults to '1'

nsheff commented 1 year ago

@donaldcampbelljr since you're looking into this toggle thing, maybe you can follow up on this very old issue.

I think this is probably already done and just needs to be closed, maybe you can make sense of the above and confirm?

donaldcampbelljr commented 1 year ago

Currently:

sel_attr = {str} 'toggle'
sel_excl = {NoneType} None
sel_incl = {NoneType} None
toggle_key = {str} 'toggle'

Per looper run --help: -g K, --toggle-key K Sample attribute specifying toggle. Default: toggle

donaldcampbelljr commented 1 year ago
sample_table: sample_annotation.csv
sample_modifiers:
  append:
    pipeline_interfaces: ../pipeline/pipeline_interface4.yaml
    toggle: 0
    toggle2: 0
    testAttr: 5

looper:
  output_dir: $HOME/hello_looper_results

looper run ./hello_looper-master/project/project_config_3.yaml --sel-attr toggle --sel-incl 1 looper run ./hello_looper-master/project/project_config_3.yaml --sel-attr toggle --sel-incl 0

Both above commands give the following result:

Looper version: 1.4.0
Command: run
Using default config. No config found in env var: ['DIVCFG']
Pipestat compatible: False

Looper finished
Samples valid for job generation: 0 of 0
Commands submitted: 0 of 5
Jobs submitted: 0

Similar result if using another attribute: looper run ./hello_looper-master/project/project_config_3.yaml --sel-attr testAttr --sel-incl 5

--toggle-key K works for me as expected.