pepkit / looper

A job submitter for Portable Encapsulated Projects
http://looper.databio.org
BSD 2-Clause "Simplified" License
20 stars 7 forks source link

plugins defaults for file names #306

Closed stolarczyk closed 3 years ago

stolarczyk commented 3 years ago

Currently our plugins produce files with the following default names:

should we change the first one to {sample.name}_sample.yaml to make the naming convention consistent?

nsheff commented 3 years ago

I actually don't mind it the way it is, since that's the old behavior.

what's the CWL plugin's version? {sample.name}_cwl.yaml ?

stolarczyk commented 3 years ago

what's the CWL plugin's version? {sample.name}_cwl.yaml ?

yes

nsheff commented 3 years ago

I think I'd leave it, on the grounds of backwards compatibility. but if you want to change it I guess I'm ok with it.

stolarczyk commented 3 years ago

following the conclusions in #307, I'll change the defaults to make names consistent:

nsheff commented 3 years ago

what about the project-included variant of the basic function? should that be a parameter instead of a separate function? if separate, it should have a separate output.

stolarczyk commented 3 years ago

Oh yeah I forgot about this one. It's a separate plugin now. So it should have a separate output and separate key to parametrize it.