search

pepkit / looper

A job submitter for Portable Encapsulated Projects
http://looper.databio.org
BSD 2-Clause "Simplified" License
20 stars 7 forks source link

redundant code in CWL plugin? #310

Closed stolarczyk closed 3 years ago

stolarczyk commented 3 years ago

@nsheff, it looks like this entire code block is not used in the plugin. What was the intent here? https://github.com/pepkit/looper/blob/5909ff15c1924ceefcca4987f2eb956a513bb364/looper/conductor.py#L124-L135 It all leads to s, which is not used downstream.

stolarczyk commented 3 years ago

I think I get it, did you mean to replace read_schema(namespaces["pipeline"]["input_schema"]) in the for loop below and iterate over s instead?

nsheff commented 3 years ago

I think you're looking at an old commit.

stolarczyk commented 3 years ago

noo.. I'm I think looking at the current state of the cwl-files branch

nsheff commented 3 years ago

it was old in my mind :). does this look better?

nsheff commented 3 years ago

I apparently hadn't finished my last test, which I just tried now.

stolarczyk commented 3 years ago

yes, thanks!