Updates test expectation for when sample name has whitespace
Fixes a few typos, missing param in docstring, and local variable name improvements
Removes requirements-dev.txt in favor of the general one (requirements-all.txt) and the test one (requirements-test.txt)
Updates pytest CI action to use requirements-test.txt
adds a bit of messaging context
Close #354
@nsheff can you please see whether these changes reflect what you'd like re: sample validation and failing the whole procedure? as is written, this makes the fewest changes to existing behavior, but rather just updates messaging a bit and fixes the test expectation. I worded my question on #354, especially the third part, a bit oddly / ambiguously, so I wasn't sure how best to read your reply.
In any case, the changes here will cause the sample to fail (and whole thing to short-circuit) if validation fails for any (probably, as you note, the only) schema. It will, however, not fail if no schema can be read / found (and therefore the sample proceeds unvalidated).
vreuter
commented
1 year ago
requirements-dev.txtin favor of the general one (requirements-all.txt) and the test one (requirements-test.txt)requirements-test.txtClose #354
@nsheff can you please see whether these changes reflect what you'd like re: sample validation and failing the whole procedure? as is written, this makes the fewest changes to existing behavior, but rather just updates messaging a bit and fixes the test expectation. I worded my question on #354, especially the third part, a bit oddly / ambiguously, so I wasn't sure how best to read your reply.
In any case, the changes here will cause the sample to fail (and whole thing to short-circuit) if validation fails for any (probably, as you note, the only) schema. It will, however, not fail if no schema can be read / found (and therefore the sample proceeds unvalidated).