pepkit / looper

A job submitter for Portable Encapsulated Projects
http://looper.databio.org
BSD 2-Clause "Simplified" License
20 stars 7 forks source link

divvy reintegration #378

Closed ayobi closed 1 year ago

ayobi commented 1 year ago

should be ready now

ayobi commented 1 year ago

I just realized you can add changes to the same pull request, I was closing and making a new pull request every time I made a change. My bad.

nsheff commented 1 year ago

Hi @ayobi -- what's the status of this PR? were you able to get all the divvy integration completed?

ayobi commented 1 year ago

Hi @nsheff, sorry for the delay, yes, all is integrated, I'll go ahead and merge PR now.

nsheff commented 1 year ago

did you finish the docs integration?

ayobi commented 1 year ago

Ah, adding that now

ayobi commented 1 year ago

Those docs have been added and the mkdocs.yaml is updated on dev, I'm not seeing any changes to https://looper.databio.org/en/dev/ though, is there anything else I need to do in order to see how it looks for the dev version of the docs?

nsheff commented 1 year ago

https://readthedocs.org/projects/looper/builds/

nsheff commented 1 year ago

I think the docs builds are failing because this might no longer be an allowed way to specify a requirement:

https://github.com/pepkit/looper/blob/8b17506c60887bf1ef738ab99816aa8c87c1ef6d/requirements/requirements-doc.txt#L5

ayobi commented 1 year ago

Ah ok. I can look into that but currently having issues running mkdocs locally, some issues with mkdocs and jinja2 that I am running into so it's hard to debug at the moment.

nsheff commented 1 year ago

it's probably solvable with a quick google search.

nsheff commented 1 year ago

that did it

nsheff commented 1 year ago

you need to update the changelog: https://looper.databio.org/en/dev/changelog/

nsheff commented 1 year ago

also the images aren't loading correctly: https://looper.databio.org/en/dev/cli_divvy/

ayobi commented 1 year ago

I'll fix that now

ayobi commented 1 year ago

Ok, fixed the images that were in the Intro for divvy. The CLI comes from a Juypter file, not sure if I need to do something extra for that but the header is rendering for that. Also, I made the entry for 1.5 in the changlog, so far I put in the divvy additions, not sure what else is coming in this release so we can modify that when we're ready.