pepkit / looper

A job submitter for Portable Encapsulated Projects
http://looper.databio.org
BSD 2-Clause "Simplified" License
20 stars 7 forks source link

looper summarize, report, table #390

Closed donaldcampbelljr closed 6 months ago

donaldcampbelljr commented 11 months ago

In 2020, looper summarize was split into report and table functions: https://github.com/pepkit/looper/pull/255

looper report is intended to create a static html report. looper table provides "Project/Sample statistics and table output generator".

Currently (in Looper 1.5.0), there are two Reporter classes (Reporter and ReporterOld) and two Tabulator classes (Tabulator and TabulatorOld). It appears that with the release of Looper 1.4.0, looper report and table were to only be used when pipestat is configured.

However, looper will currently still use the ReporterOld and TabulatorOld classes if pipestat is not configured.

We've also recently moved the report generation to pipestat.summarize such that looper report (when configured to use pipestat) will call Reporter class which uses pipestat.sumamrize to generate the html report. However, looper table and Tabulator Class are still completely contained within looper.

Some questions:

Thoughts on path forward:

nsheff commented 11 months ago

Yes. I think you are thinking in exactly the right way.