pepkit / looper

A job submitter for Portable Encapsulated Projects
http://looper.databio.org
BSD 2-Clause "Simplified" License
20 stars 7 forks source link

looper is forcing the pipeline file to be executable, even if the command template doesn't execute it #420

Closed donaldcampbelljr closed 6 months ago

donaldcampbelljr commented 9 months ago

looper is forcing the pipeline file to be executable, even if the command template doesn't execute it (I was using 'python script.py').

donaldcampbelljr commented 9 months ago

Currently, in Looper's conductor.py, we check if the commands in the pl_iface is executable: https://github.com/pepkit/looper/blob/145c0d6796d45e45a4ec133beed5be30e1860553/looper/conductor.py#L724-L725

This was implemented as a potential solution to this: https://github.com/pepkit/looper/issues/195

Specifically, it is using: is_command_callable from ubiquerg

https://github.com/pepkit/ubiquerg/blob/bbca867a7c3581bad51723977db3791d999d8591/ubiquerg/system.py#L11-L30

nsheff commented 9 months ago

This is totally unrelated to #195, actually. That's about the commands in a pipeline.

The problem is that this is referring to the pipeline script itself. These are two completely different things.

donaldcampbelljr commented 9 months ago

The original changes are now reverted.