search

pepkit / looper

A job submitter for Portable Encapsulated Projects
http://looper.databio.org
BSD 2-Clause "Simplified" License
20 stars 7 forks source link

Update to yacman 0.9.3 to prepare for the new YAMLConfigManager #451

Closed nsheff closed 4 months ago

nsheff commented 5 months ago

Work toward accommodating yacman v1.

Update the way YAMLConfigManager objects are constructed, read, and written following the upgrade guide in the yacman readme: https://github.com/databio/yacman

simeoncarstens commented 5 months ago

Currently, looper uses a (at least, according to the comment) copy & pasted divvy module, which in turn uses YAMLConfigurationManager (https://github.com/pepkit/looper/blob/1468956dde66abf5b853c80eaeaee2d411bfad64/looper/divvy.py#L31). That would need to be adapted, too.

donaldcampbelljr commented 4 months ago

I've finished implementing the FutureYamlConfigManager in this PR but it needs review.

nsheff commented 4 months ago

looks much cleaner!