pepkit / looper

A job submitter for Portable Encapsulated Projects
http://looper.databio.org
BSD 2-Clause "Simplified" License
20 stars 7 forks source link

Appending "command_extra" for looper runp appears to be broken #475

Closed donaldcampbelljr closed 3 months ago

donaldcampbelljr commented 3 months ago

test_cmd_extra_project in test_run.py:

Appending "command_extra" args shows up in the submission scripts when using looper run but not when using looper runp

donaldcampbelljr commented 3 months ago

I believe this may have been opened in error. I cannot reproduce it, and the test seems to be working fine for both run and runp commands. Closing for now.

donaldcampbelljr commented 3 months ago

I found the broken test and realized that I was not modifying the project config in a way that the submission conductor was expecting.

For project level (runp command):

name: looper_advanced_test
pep_version: 2.0.0
sample_table: annotation_sheet.csv
looper:
  command_extra: string

For sample levels (runcommand):

name: looper_advanced_test
pep_version: 2.0.0
sample_table: annotation_sheet.csv
sample_modifiers:
  append:
    command_extra: string
    attr: val

Leaving this as closed.