search

pepkit / pepdbagent

Database for storing sample metadata
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Group of peps #100

Closed khoroshevskyi closed 6 months ago

khoroshevskyi commented 10 months ago

Added BRAND NEW functionality Group of PEPs

nsheff commented 10 months ago

At first glance, this looks to be like really a lot of code for something that I think could have been accomplished with very little new code using the ideas presented here: https://github.com/pepkit/pephub/issues/129

I only think we should go this route if there's a compelling reason not to do that. Can you articulate such a reason?

My feeling is that the approach in this PR is at once 1. less performant; and 2. harder to maintain, than my proposal. I'm open to argument if you disagree, but if you can't, then I suggest you try the other approach instead.

khoroshevskyi commented 6 months ago

After the discussion, the decision was made to go with POP instead of a group of peps