Dev

[khoroshevskyi]

added new get_annotations functions

[nleroy917]

Are tests failing because of database connection issues?

[khoroshevskyi]

Are tests failing because of database connection issues?

Yes

[nleroy917]

Some small things with questions. Biggest being splitting up the upload_project function into two functions. Also unit tests

[khoroshevskyi]

@nleroy917 @nsheff I have reviewed all comment's and fixed it. In my opinion there is one think we should add: Documentation.

[nleroy917]

I am testing this with pephub and it looks like you might be missing a line in the requirements file for coloredlogs

[nleroy917]

Also, since you've changed the class name to PepAgent, I think the __init__.py file needs to reflect this:

Otherwise, I get: ImportError: cannot import name 'PepAgent' from 'pepagent'

[khoroshevskyi]

Also, since you've changed the class name to PepAgent, I think the __init__.py file needs to reflect this:

Otherwise, I get: ImportError: cannot import name 'PepAgent' from 'pepagent'

Good catch! Additionally we are thinking about changing pepagent name to pepdbagent and PepDbAgent class. What do you thing about that naming @nleroy917 ? I think this name can be to long but it reproduces actual meaning of this package @nsheff

[nleroy917]

Additionally we are thinking about changing pepagent name to pepdbagent and PepDbAgent class

Yeah that sounds good to me. Or maybe Connection? Similar to the relational database drivers. E.g. psycopg2.connect -> Connection.

I'm impartial, however.

[khoroshevskyi]

I like it!

[khoroshevskyi]

@nleroy917 @nsheff I think, it's ready.

[nleroy917]

I think, it's ready.

If you dont mind, before a merge I might test drive locally with pephub.