pepkit / pepdbagent

Database for storing sample metadata
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Upload project method should be corrected #41

Closed khoroshevskyi closed 1 year ago

khoroshevskyi commented 1 year ago
    >     1. update_project. In my opinion both `upload project` (update=True) an `update_project` have to be in pepdbagent. Why? Because there can be 3 update cases:
   a. project doesn't exist in database, and user wants to upload it, and if exists we want to update it. (use upload_project)
   b. project doesn't exist in database, and user wants to update it, only if it exists. (use update_project)
   c. upload project if it doesn't exist (use upload_project)

This should be: add_project(overwrite=True, update_only=False)

a: add_project(overwrite=True, update_only=False) b: add_project(update_only=True) c: add_project(overwrite=False)

Originally posted by @nsheff in https://github.com/pepkit/pepdbagent/issues/40#issuecomment-1287154857

++ ON CONFLICT DO UPDATE - use this function to update project

khoroshevskyi commented 1 year ago