pepkit / pepdbagent

Database for storing sample metadata
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

`pepdbagent.Connection.delete_project` has the wrong return type. #61

Closed nleroy917 closed 1 year ago

nleroy917 commented 1 year ago

I noticed that VSCode was giving some odd syntax highlighting:

image

It seemed to think the return statement was never going to be reached. I noticed that the delete_project function was returning a NoReturn. I think this is incorrect. It should return None. NoReturn indicates that the function will never return a value (either it never terminates or it always throws an exception).