search

pepkit / pepdbagent

Database for storing sample metadata
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

v0.4.0 #84

Closed khoroshevskyi closed 1 year ago

khoroshevskyi commented 1 year ago

Major changes in the new pepdbagent include:

1) Switched to SQLAlchemy ORM. 2) Added a pep_schema column to the database. 3) Implemented a new testing approach. 4) Introduced the functionality sort by in annotations module. 5) Temporarily disabled the search by description due to long processing time and impact on the database. 6) Included timezone support in the database. 7) Changed namespace and names to be lowercase, making them case insensitive. 8) Streamlined the database schema creation process, with tables now created dynamically as needed.

khoroshevskyi commented 1 year ago

typos were fixed

nsheff commented 1 year ago

What do you think of increasing the line length limit to 99? This is allowable with PEP. I ask because there are a lot of places where you are getting expanded out to lots of lines because of chained sqlaclhemy commands.

If you want to , you could follow what we did in pipestat. Add this to the repo:

https://github.com/pepkit/pipestat/blob/sqlmodel/pyproject.toml

Then use black . and it will format to 99 char lines instead. Just an idea, feel free to ignore.