search

pepkit / pepdbagent

Database for storing sample metadata
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

v0.5.0 #90

Closed khoroshevskyi closed 11 months ago

khoroshevskyi commented 12 months ago

Retructured all db! Now we have 3 tables: projects, samples, and subsamples One step closer to:

nsheff commented 11 months ago

I notice there's not samples module. are you planning to add that later?

nsheff commented 11 months ago

usually there's a newline between description and params in docstrings, but I see several docstrings that are missing that now. can you update your docstrings?

eg:

https://github.com/pepkit/pepdbagent/blob/f9c94a0a406a9b71ba45b2c67807ada60cf29e33/pepdbagent/modules/annotation.py#L238-L239

nsheff commented 11 months ago

is this docstring correct?

https://github.com/pepkit/pepdbagent/blob/f9c94a0a406a9b71ba45b2c67807ada60cf29e33/pepdbagent/modules/project.py#L27

If so I recommend this be named PEPDatabaseProjects instead of PEPDatabaseProject. But I think that is wrong and it only can represent a single Project (not Projects).

khoroshevskyi commented 11 months ago

I think I've addressed all comments